Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: referendum-tx to polkadot-api #25

Closed
wants to merge 3 commits into from
Closed

refactor: referendum-tx to polkadot-api #25

wants to merge 3 commits into from

Conversation

ryanleecode
Copy link

@ryanleecode ryanleecode commented Nov 2, 2023 •
edited
Loading

As discussed offline, we are migrating internal tooling to use polkadot-api. This changes updates the referendum-tx.ts to use polkadot-api instead of polkadotjs. Note the use of autogenerated scale codecs, these were created by the polkadot-api CLI.

@ryanleecode ryanleecode force-pushed the refractor/referendum-tx-polkadot-api branch 2 times, most recently from cbe0943 to f190d05 Compare November 2, 2023 19:05
@ryanleecode ryanleecode force-pushed the refractor/referendum-tx-polkadot-api branch from f190d05 to faf77b4 Compare November 2, 2023 19:12
@ryanleecode ryanleecode marked this pull request as ready for review November 2, 2023 19:27
@ryanleecode ryanleecode requested a review from a team as a code owner November 2, 2023 19:27
@ryanleecode ryanleecode force-pushed the refractor/referendum-tx-polkadot-api branch from 1dd35e7 to 372052d Compare November 2, 2023 19:36
@rzadp
Copy link
Contributor

rzadp commented Nov 2, 2023

Thanks @ryanleecode :)

A couple of questions:

  • Is there anything against adding @polkadot-api/cli as a devDependency and generating the generated files as part of the build process here?
  • I thought that we'll be able to use nicer names of pallets and functions (referenda as opposed to module: 61). Is it not the case?

@ryanleecode
Copy link
Author

Thanks @ryanleecode :)

A couple of questions:

  • Is there anything against adding @polkadot-api/cli as a devDependency and generating the generated files as part of the build process here?
  • I thought that we'll be able to use nicer names of pallets and functions (referenda as opposed to module: 61). Is it not the case?

I just spoke with my team and we have a higher level API in the works. I just jumped the gun on integrating this one. We'll reopen with a new PR using the higher level API when its finished :)

@ryanleecode ryanleecode closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanleecode @rzadp